-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate linkcheck views to ModelAdmin
#189
base: master
Are you sure you want to change the base?
Conversation
b258fb6
to
3fdb3b8
Compare
I'm not completely against this, but I would not like to lose some UI niceties from the previous layout. Typically, having a Recheck/Ignore buttons just near the affected link is much nicer than having to check a box at the left, go on the top of the page, open a select, chose an action and clicking on the Go button. The view/edit object links are also nice shortcuts. |
ba97e13
to
b28d881
Compare
@claudep I now included buttons into the list, is this how you envisioned it? |
It begins to look rather good, however the big problem currently in my opinion is the width of the table. Even with a screen width of >1900 (~1700 with the left tab hidden), the right of the table is not accessible at all, with no horizontal scrollbar, and then the buttons are not visible (unless you make some gym trying to display the right part of the table). I know it's a current problem with the Django admin in general, however in our use case, it's really bad. Do you have an idea to mitigate that issue? |
b28d881
to
e58bdbc
Compare
@claudep I played a bit around with CSS, I think now it's maybe not pretty, but at least usable on small screen resolutions, what do you think? |
ModelAdmin
for Url and Link modelsreport
viewFixes #186